fix(DBLink): leading/trailing whitespace when using icons (by mitosis update) #4310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the builder-io group with 2 updates: [@builder.io/mitosis](https://github.com/BuilderIO/mitosis) and [@builder.io/mitosis-cli](https://github.com/BuilderIO/mitosis). Updates `@builder.io/mitosis` from 0.9.2 to 0.11.0 - [Release notes](https://github.com/BuilderIO/mitosis/releases) - [Commits](https://github.com/BuilderIO/mitosis/compare/@builder.io/[email protected][email protected]/[email protected]) Updates `@builder.io/mitosis-cli` from 0.9.2 to 0.11.0 - [Release notes](https://github.com/BuilderIO/mitosis/releases) - [Commits](https://github.com/BuilderIO/mitosis/compare/@builder.io/[email protected][email protected]/[email protected]) --- updated-dependencies: - dependency-name: "@builder.io/mitosis" dependency-version: 0.11.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: builder-io - dependency-name: "@builder.io/mitosis-cli" dependency-version: 0.11.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: builder-io ... Signed-off-by: dependabot[bot] <[email protected]>
# Conflicts: # package-lock.json # package.json # packages/components/package.json
mfranzke
previously approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Mitosis library from version 0.10.0 to 0.12.1 to fix related issues. The update enables Angular signals support and removes outdated workarounds that are no longer needed with the newer version.
Key changes include:
- Updated Mitosis dependencies to version 0.12.1
- Added Angular signals configuration with writeable properties for form components
- Removed deprecated trackBy workarounds and lifecycle management code
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Mitosis dependencies from 0.10.0 to 0.12.1 |
| configs/angular/index.cjs | Enables attribute passing in Angular configuration |
| Multiple component files | Adds Angular signals metadata with writeable properties |
| scripts/post-build/angular.ts | Removes deprecated workarounds and updates lifecycle handling |
| scripts/post-build/components.ts | Removes trackBy function workarounds |
packages/components/src/components/custom-select-list-item/custom-select-list-item.lite.tsx
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
mfranzke
changed the title
mfranzke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #4072
Types of changes
Further comments